[PATCH] alauda: do not use stack for URB transfer_buffers

Jussi Kivilinna jussi.kivilinna at iki.fi
Wed Aug 7 01:50:53 EDT 2013


On 06.08.2013 19:49, Jörn Engel wrote:
> On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote:
>>
>> Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to
>> be DMA-able, which stack is not.
>>
>> Patch is only compile tested.
> 
> I have tested the driver back when I wrote it.  Not sure why it worked
> then, maybe the chip in my notebook back then didn't care about
> alignment or I just got lucky with the memory allocations.

You might not see problems with your hardware/architecture.

"Documentation/DMA-API-HOWTO.txt" discusses about "What memory is DMA'able?".

> 
> My old test hardware was likely thrown out in the last move, about two
> years back.  Performance sucked anyway, 400kB/s was the limit.  Maybe
> we should just remove the driver and not spend any more time on it?
> 
> Jörn
> 
> --
> Victory in war is not repetitious.
> -- Sun Tzu
> 




More information about the linux-mtd mailing list