[PATCH 6/6] mtd: ofpart: add compatible check for child nodes
computersforpeace at gmail.com
Mon Aug 5 14:56:14 EDT 2013
It seems Artem applied this to l2-mtd.git. One comment below.
On Mon, Aug 5, 2013 at 4:33 AM, Josh Wu <josh.wu at atmel.com> wrote:
> Add device tree mail list to CC.
> On 8/5/2013 7:14 PM, Josh Wu wrote:
>> In case that the nand device will support some features like Nand Flash
>> Controller, we want to make the sub feature as a sub node of nand device.
>> Use such organization it is easy to enable/disable feature, also it is
>> compatible and more readable.
>> If the sub-node has a compatible property then it is a driver not
>> Signed-off-by: Josh Wu <josh.wu at atmel.com>
>> Acked-by: Brian Norris <computersforpeace at gmail.com>
>> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
>> v3 --> v4:
>> - remove the 'len' parameter, just use NULL.
>> - refine the commit message.
>> - also add a NOTE in devicetree/bindings/mtd/partition.txt.
>> .../devicetree/bindings/mtd/partition.txt | 1 +
>> drivers/mtd/ofpart.c | 13 ++++++++++++-
>> 2 files changed, 13 insertions(+), 1 deletion(-)
>> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
>> index 553d6d6..30fcea1 100644
>> --- a/drivers/mtd/ofpart.c
>> +++ b/drivers/mtd/ofpart.c
>> @@ -20,6 +20,10 @@
>> #include <linux/slab.h>
>> #include <linux/mtd/partitions.h>
>> +static bool node_has_compatible(struct device_node *pp)
>> + return of_get_property(pp, "compatible", NULL);
Missing a trivial additional newline here. I amended the patch in l2-mtd.git.
>> static int parse_ofpart_partitions(struct mtd_info *master,
>> struct mtd_partition **pparts,
>> struct mtd_part_parser_data *data)
More information about the linux-mtd