nand_base: fix for ONFI chips that do not support GET/SET FEATURES
David Mosberger-Tang
dmosberger at gmail.com
Tue Apr 30 19:39:22 EDT 2013
The attached patch is relative to linux-mtd. It fixes a problem with
NAND-chips that are ONFI-compliant but don't support the SET/GET
FEATURES commands (such as Spansion S34Mx).
--david
-------------- next part --------------
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index dfcd0a5..13c8043 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2720,7 +2720,9 @@ static int nand_onfi_set_features(struct mtd_info *mtd, struct nand_chip *chip,
{
int status;
- if (!chip->onfi_version)
+ if (!chip->onfi_version ||
+ // supports GET/SET FEATURES?
+ !(le16_to_cpu(chip->onfi_params.opt_cmd) & 4))
return -EINVAL;
chip->cmdfunc(mtd, NAND_CMD_SET_FEATURES, addr, -1);
@@ -2741,7 +2743,9 @@ static int nand_onfi_set_features(struct mtd_info *mtd, struct nand_chip *chip,
static int nand_onfi_get_features(struct mtd_info *mtd, struct nand_chip *chip,
int addr, uint8_t *subfeature_param)
{
- if (!chip->onfi_version)
+ if (!chip->onfi_version ||
+ // supports GET/SET FEATURES?
+ !(le16_to_cpu(chip->onfi_params.opt_cmd) & 4))
return -EINVAL;
/* clear the sub feature parameters */
More information about the linux-mtd
mailing list