UBIFS: make space fixup work in the remount case
Dan Carpenter
dan.carpenter at oracle.com
Mon Apr 15 06:19:36 EDT 2013
On Mon, Apr 15, 2013 at 01:11:33PM +0300, Artem Bityutskiy wrote:
> On Mon, 2013-04-15 at 12:59 +0300, Dan Carpenter wrote:
> > 1571 if (c->space_fixup) {
> > 1572 err = ubifs_fixup_free_space(c);
> > 1573 if (err)
> > 1574 return err;
> > ^^^^^^^^^^
> > Shouldn't this be a "goto out?". We're holding the c->umount_mutex.
>
> Hi Dan, I fixed this up and answered the reporter:
> https://patchwork.kernel.org/patch/2284681/
>
> It is now 'goto out'. Thanks!
Huh... That wasn't who I expected to report it. :P It's good to
know that these kind of bugs don't last very long.
regards,
dan carpenter
More information about the linux-mtd
mailing list