[PATCH] mtd: bcm47xxsflash: just use memcpy_fromio for reading

[Artem Bityutskiy]

On Thu, 2012-09-20 at 11:00 +0200, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
> ---
> It doesn't generate any errors on normal compilation, but I wasn't able
> to test it with "verify". This tool defeated me ;/
> 
> First I cloned dedekind/maintaining.git but it didn't run because or
> lacking aiaiai.
> 
> So I've cloned dedekind/aiaiai.git.
> 
> Then I had to move aiaiai to ~/git/aiaiai to let "verify" find it.
> 
> So I was able to use verify:
> time ./verify ../l2-mtd/ mips-bcm47xx_defconfig < ../l2-mtd/0001-mtd-bcm47xxsflash-just-use-memcpy-for-reading.patch
> but it didn't work because patch was already applied. My bad, but... it
> took 2m17.277s to verify to realize that. And that magic commit/message
> wasn't helpful:

Well, before doing anything with your tree, we clone it to a temporary
location (in the workdir, which can specify), that probably took 2
minutes in your machine.

> Failed to apply patch(es) with git am on top of:
> 0f1afc8 Quick fixes - applied by aiaiai

After this there should have been the right commit. But I agree this is
confusing, I'll look how I can improve this.

> So I've removed patch from my tree, and tried again. This time it took
> 3m14.398s just to display:
> [2012-09-20 10:39:10] aiaiai-make-kernel: Program "aiaiai-locker" is required but not found in PATH
> 
> I just wanted to add ~/git/aiaiai to my $PATH, but noticed it doesn't contain
> aiaiai-locker anyway... I gave up :|

Because you need to type "make". This is written in the docs. Dunno, how
would I make sure users do not forget to type make before running? I can
improve the error message though, and put a hint there.

> I appreciate your work on additional quality tools, but apart from good
> code it also need to be easy-usable to make ppl use it :|

Thanks for feed-back, appreciated!

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120920/48e7ab56/attachment.sig>