[PATCH V2] mtd: basic (read only) driver for BCMA serial flash

[Artem Bityutskiy]

On Tue, 2012-09-11 at 12:35 +0200, Rafał Miłecki wrote:
> 2012/9/11 Artem Bityutskiy <dedekind1 at gmail.com>:
> > On Mon, 2012-09-03 at 21:07 +0200, Rafał Miłecki wrote:
> >> This registers MTD driver for serial flash platform device. Right now it
> >> supports reading only, writing still has to be implemented.
> >> At this point it's marked as BROKEN, because it requires code present in
> >> net tree that wasn't mainlined yet.
> >>
> >> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
> >
> > What are exactly the changes it depends on? URL? Are they staged for
> > 3.7?
> 
> http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commitdiff;h=23cb3b2121323443834296a8ecb582b8aeb78d75
> http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commitdiff;h=d57ef3a6a2eeb88df47e892c66692e3f59722ffe

Please, remove "BROKEN" and re-send the compilable patch against the
l2-mtd.git tree. I've pulled Dave Miller's tree with your patches into
l2-mtd.git. Thanks!

> Well, I just didn't implement writing yet (it's more complicated than
> that trivial reads) and I didn't know the correct values for the above
> ones. I just set writesize to 1 to avoid some WARN/BUG (not remember
> right now).

OK. Just add 'mtd->writebufsize = mtd->writesize = 1; for now.

> In case some other driver handling platform device was loaded earlier.
> Is that wrong?

I do not really understand why you need this - can the general code
really call the removal method and the platform data be NULL? If not,
kill this check - if this happens, this is a bug and we'll end up with
an oops. If it can, please, explain in more details how this can
happen. 

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120916/705c4f24/attachment.sig>