[PATCH] mtd: nand: docg4: ecc.read_page() returns 0 on uncorrectible errors
Mike Dunn
mikedunn at newsguy.com
Tue Sep 11 11:50:50 EDT 2012
Currently the docg4's ecc.read_page() method returns -EBADMSG when uncorrectible
bitflips occur. This is wrong; 0 should be returned in this case. An error
code should only be returned by this method in the case of a hardware error
(probably -EIO).
Signed-off-by: Mike Dunn <mikedunn at newsguy.com>
---
drivers/mtd/nand/docg4.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c
index 793921e..deb718c 100644
--- a/drivers/mtd/nand/docg4.c
+++ b/drivers/mtd/nand/docg4.c
@@ -776,6 +776,8 @@ static int read_page(struct mtd_info *mtd, struct nand_chip *nand,
}
writew(0, docptr + DOC_DATAEND);
+ if (bits_corrected == -EBADMSG) /* uncorrectible errors */
+ return 0;
return bits_corrected;
}
--
1.7.3.4
More information about the linux-mtd
mailing list