[PATCH] mtd: nand: omap2: fix error path

Afzal Mohammed afzal at ti.com
Tue Sep 11 02:28:54 EDT 2012


Let probe return error value if gpmc terminal
count interrupt could not be obtained

Signed-off-by: Afzal Mohammed <afzal at ti.com>
---
Hi,

My commit (now in l-o/devel-gpmc),

"bd4156f  mtd: nand: omap2: use gpmc provided irqs"

did not propogate error code properly due to
which this fix was required.

But this has not been mentioned in commit message
as it is not yet in mainline.

Regards
Afzal

 drivers/mtd/nand/omap2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 337cf0a..27293e3 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1404,6 +1404,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev)
 		info->gpmc_irq_count = platform_get_irq(pdev, 1);
 		if (info->gpmc_irq_count <= 0) {
 			dev_err(&pdev->dev, "error getting count irq\n");
+			err = -ENODEV;
 			goto out_release_mem_region;
 		}
 		err = request_irq(info->gpmc_irq_count,	omap_nand_irq,
-- 
1.7.0.4




More information about the linux-mtd mailing list