[PATCH 1/2] mtd: gpmi-nand: Convert to platform driver

[Marek Vasut]

Dear Fabio Estevam,

> Hi Marek,
> 
> On Wed, Sep 5, 2012 at 3:55 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Fabio Estevam,
> > 
> >> From: Fabio Estevam <fabio.estevam at freescale.com>
> >> 
> >> Using module_platform_driver() makes the code smaller and cleaner.
> > 
> > You did not document the dev_info() etc. addition, dunno if it's
> > important or not.
> 
> It is not an addition. I just moved  "pr_info("driver registered.\n")"
>  from gpmi_nand_init, (which is removed by this patch) to the probe
> function.

Ah, just noticed. I'd say drop it completely then, there's now value in this 
print (or make it pr_debug() ). Besides, the init call was called only once if 
compiled in / every time if built as a module. The probe call is done per GPMI 
nand driver instance.

> Regards,
> 
> Fabio Estevam

Best regards,
Marek Vasut