[PATCH 1/2 RFC v2] mtd/uclinux: support ROM and allow passing the base address
Greg Ungerer
gerg at snapgear.com
Mon Oct 15 21:13:05 EDT 2012
Hi Uwe,
On 15/10/12 16:58, Uwe Kleine-König wrote:
> On Mon, Oct 15, 2012 at 02:14:55PM +1000, Greg Ungerer wrote:
>>> mapp->virt = ioremap_nocache(mapp->phys, mapp->size);
>>> @@ -76,9 +83,18 @@ static int __init uclinux_mtd_init(void)
>>>
>>> simple_map_init(mapp);
>>>
>>> - mtd = do_map_probe("map_ram", mapp);
>>> + mapp->name = "ROM";
>>> + mtd = do_map_probe("map_rom", mapp);
>>> + if (!mtd) {
>>> + /* fall back to ram probing for compatibility reasons */
>>> + mapp->name = "RAM";
>>> + mtd = do_map_probe("map_ram", mapp);
>>> + if (mtd && IS_ENABLED(CONFIG_MTD_ROM))
>>> + pr_err("Failed to map rom, but ram succeeded. Please report this issue!\n");
>>
>> Do we really want this message?
>> My predominate usage of this code is in RAM mappings. Network
>> loading kernel+filesystem images on bare boards. Anyone who wants
>> to know and is looking in the kernel boot messages will see
>> something like:
>>
>> Creating 1 MTD partitions on "RAM":
>> 0x000000000000-0x0000000d8000 : "ROMfs"
>>
>> So they will know what type of mapping it was loaded from.
> I want it because if nobody reports it it might well be possible to drop
> map_ram support.
I am not sure I follow. The message is only printed if both ROM and
RAM mappings are enabled. Many of the configs I use only have RAM
mappings enabled.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg at snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
More information about the linux-mtd
mailing list