[PATCH] [MTD] Adjust the NOR CFI flash timeouts to round better
Jason Gunthorpe
jgunthorpe at obsidianresearch.com
Mon Oct 15 13:49:07 EDT 2012
On Mon, Oct 15, 2012 at 10:31:41AM -0700, David Woodhouse wrote:
> > > So it's not *entirely* bogus, but it should certainly be cleaned up to
> > > use the msecs_to_jiffies() helpers... or preferably not use jiffies at
> > > all, perhaps.
> >
> > No doubt this is part of why I've seen failures on my boards, the
> > timeout is too short by half and rounded wrong :)
>
> Yeah, the rounding by +2 is confusing. I'm sure it's wrong, but at least
> I can kind of see where it came from.
The rounding by +2? I think even if you used msecs_to_jiffies you'd
need to add a +1 to the result to make the timeout algorithm work
right..
Is there a better way to do these timeouts?
> > A quick grep shows many cases in drivers/mtd that use division of HZ,
> > what would you like to see done here?
>
> I'd like someone with infinite amounts of free time to go through and
> clean them all up :)
lol! Would you accept msecs_to_jiffies conversion for the cfi files?
> > ?? That's '??s', not 'us', for next time the patch is submitted. Welcome
> > to the 21st century.
> >
> > Hmm.. I may need a new terminal and/or mail reader ;)
>
> As I said... welcome to the 21st century. Seriously though, what are you
> using that isn't capable of even *preserving* UTF-8 when you reply to
> it? That's really quite broken, and has been considered so for a decade
> or more already.
I deliberately made it not preserve UTF-8 for this posting, it is just
rxvt, nobody ever put unicode into it.
Jason
More information about the linux-mtd
mailing list