[PATCH 07/11] fsmc/nand: Provide contiguous buffers to dma
dedekind1 at gmail.com
Mon Oct 15 09:18:24 EDT 2012
On Fri, 2012-10-12 at 09:25 +0530, Vipin Kumar wrote:
> The buffers provided to the driver are actually user buffers. The reason
> I say that is because the generic nand test modules eg
> drivers/mtd/nand/mtd_stresstest.c calls mtd->_read with a user buffer as
> an argument
I am not sure what does "user" buffers mean, but they are vmalloced()
buffer, not kmalloc()'ed, so they are not physically contiguous.
> This same buffer directly trickles down to the driver
> Artem, should we clearly cast this buffer as a user pointer instead of
> just a 'uint8_t *'.
They are not "_user", they are really kernel buffers. Or what do you
mean, which exactly type do you suggest?
This stuff is something many people are bringing up for many years
already. Drivers that do DMA do not cope with vmalloc()ed memory well,
and we grew a number of hacks in several drives. I mean, hacks like the
one you are introducing to your driver.
I'd solve the problem by changing the in-kernel mtd users to use
physically-contiguous memory instead. The following are the users I can
UBI, UBIFS, JFFS2, mtdtests and probably mtdswap.
They use vmalloc() when they need to read/write entire eraseblock, which
is usually 128KiB or 256KiB, and kmalloc() that much may fail if the
memory is fragmented.
In many cases, it is easy to read/write in smaller chunk, but several
times. E.g., mtdtests could be changed.
In some cases, it is not easy, though.
First thing which comes to mind is that in modern kernels memory
fragmentation is not that big issue as it used to be. So may be
kmalloc() the memory is not that bad nowadays? We have page migration,
memory compaction, etc?
I'd really prefer to just switch to kmalloc() everywhere instead of
adding hacks like this to the drivers. Then if this is a problem for
someone, he can fix it by either switching to smaller buffers (possible
in many places), or by improving memory fragmentation issues on his
system, or by just using CMA.
We can even have an mtd-wide funcion which will try kmalloc(), and if
that fails, fall-back to CMA.
Then we can add a guard check to all mtd function which accept a buffer
and WARN() if it not physically contiguous.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: This is a digitally signed message part
More information about the linux-mtd