[PATCH 1/6] bcma: export PLL reading function

Artem Bityutskiy dedekind1 at gmail.com
Thu Oct 11 05:51:44 EDT 2012


On Thu, 2012-09-27 at 13:55 +0200, Rafał Miłecki wrote:
> This is required by NAND flash driver for initializing wait counters.
> 
> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
> ---
> 0001-bcma-export-PLL-reading-function.patch                           
> Successfully built configuration "mips-bcm47xx_defconfig,mips,mips-linux-", no issues

I think you did not enable the driver in the defconfig.

Tested the patch(es) on top of the following commits:
e3134a5 Quick fixes - applied by aiaiai
a7c1993 mtd: fsl_elbc_nand: remove unnecessary badblock_pattern
03ba2bf mtd: ofpart: Fix incorrect NULL check in parse_ofoldpart_partitions()
c525349 mtd: m25p80: add support for the windbond w25q256 chip

--------------------------------------------------------------------------------

Successfully built configuration "mips-bcm47xx_defconfig,mips,mips-linux-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c: In function 'bcm47xxnflash_ops_bcm4706_init':
+drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c:253:6: warning: variable 'col_mask' set but not used [-Wunused-but-set-variable]

--------------------------------------------------------------------------------

checkpatch.pl has some complaints:

--------------------------------------------------------------------------------

checkpatch.pl results for patch "[PATCH 2/6] mtd: prepare place for BCMA NAND flash driver(s)"

WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully
#33: FILE: drivers/mtd/nand/Kconfig:449:
+config MTD_NAND_BCM47XXNFLASH

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#113: FILE: drivers/mtd/nand/bcm47xxnflash/main.c:24:
+static const char *probes[] = { "bcm47xxpart", NULL };

total: 0 errors, 2 warnings, 145 lines checked

--------------------------------------------------------------------------------

checkpatch.pl results for patch "[PATCH 4/6] mtd: bcm47xxnflash: support for NAND_CMD_READID command"

WARNING:LONG_LINE: line over 80 characters
#120: FILE: drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c:106:
+                       b47n->id_data[i] = bcma_cc_read32(b47n->cc, BCMA_CC_NFLASH_DATA) & 0xFF;

total: 0 errors, 1 warnings, 134 lines checked

--------------------------------------------------------------------------------

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20121011/20522b8c/attachment.sig>


More information about the linux-mtd mailing list