[PATCH] [RFC] mtd/uclinux: support ROM and allow passing the base address
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Thu Oct 11 02:13:53 EDT 2012
On Thu, Oct 11, 2012 at 12:21:59AM -0400, Mike Frysinger wrote:
> On Mon, Oct 8, 2012 at 11:25 AM, Uwe Kleine-König wrote:
> > --- a/drivers/mtd/maps/uclinux.c
> > +++ b/drivers/mtd/maps/uclinux.c
> > @@ -23,12 +23,13 @@
> >
> > /****************************************************************************/
> >
> > -struct map_info uclinux_ram_map = {
> > - .name = "RAM",
> > - .phys = (unsigned long)__bss_stop,
> > +static struct map_info uclinux_ram_map = {
> > .size = 0,
> > };
>
> this change will break Blackfin systems. i mentioned last time
> someone tried to make this and we talked about adding a comment to
> prevent future breakage, but that seems to not have happened.
yeah, I really think adding a comment would be the right thing as I
don't see what could be the problem here you're talking about.
> i don't think's necessary either for the larger change here. use the logic:
> if (physaddr != -1)
> mapp->phys = physaddr;
> and keep the default initialization.
> -mike
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-mtd
mailing list