[patch] UBIFS: use kmalloc_array() in recomp_data_node()

Artem Bityutskiy dedekind1 at gmail.com
Thu Nov 22 05:31:37 EST 2012


On Sat, 2012-11-17 at 18:11 +0300, Dan Carpenter wrote:
>  	out_len = le32_to_cpu(dn->size);
> -	buf = kmalloc(out_len * WORST_COMPR_FACTOR, GFP_NOFS);
> +	buf = kmalloc_array(out_len, WORST_COMPR_FACTOR, GFP_NOFS);
>  	if (!buf)
>  		return -ENOMEM;

I think this makes the code unreadable, because we really allocate a
buffer, not an array.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20121122/843d24f4/attachment.sig>


More information about the linux-mtd mailing list