[PATCH 2/2] mtd: s3c2410: Fix potential NULL pointer dereference error
Sachin Kamat
sachin.kamat at linaro.org
Thu Nov 8 05:08:44 EST 2012
'set' is tested for NULL. But subsequently accessed without the check.
Thus making it conditional to avoid NULL pointer dereferencing.
Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
---
drivers/mtd/nand/s3c2410.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index dfb8636..00fc12f 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -730,11 +730,11 @@ static void s3c2410_nand_add_partition(struct s3c2410_nand_info *info,
struct s3c2410_nand_mtd *mtd,
struct s3c2410_nand_set *set)
{
- if (set)
+ if (set) {
mtd->mtd.name = set->name;
-
- mtd_device_parse_register(&mtd->mtd, NULL, NULL,
- set->partitions, set->nr_partitions);
+ mtd_device_parse_register(&mtd->mtd, NULL, NULL,
+ set->partitions, set->nr_partitions);
+ }
}
/**
--
1.7.4.1
More information about the linux-mtd
mailing list