[PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback
bharrosh at panasas.com
Thu Nov 1 18:23:54 EDT 2012
On 11/01/2012 01:22 PM, Jeff Layton wrote:
> Hmm...I don't know...
> I've never been crazy about using the page lock for this, but in the
> absence of a better way to guarantee stable pages, it was what I ended
> up with at the time. cifs_writepages will hold the page lock until
> kernel_sendmsg returns. At that point the TCP layer will have copied
> off the page data so it's safe to release it.
> With this change though, we're going to end up blocking until the
> writeback flag clears, right? And I think that will happen when the
> reply comes in? So, we'll end up blocking for much longer than is
> really necessary in page_mkwrite with this change.
Hmm OK, that is a very good point. In that case it is just a simple
nack on Darrick's hunk to cifs. cifs is fine and should not be touched
More information about the linux-mtd