[PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller

Wed May 16 05:25:53 EDT 2012

On Tue, 2012-05-15 at 22:47 +0800, Josh Wu wrote:
> +	while (!(pmerrloc_readl(host->pmerrloc_base, ELISR)
> +		 & PMERRLOC_CALC_DONE))
> +		cpu_relax();

How about some kind of time-out in something goes wrong?

> +		dev_warn(host->dev, "Only 2048 page size is currently " \
> +			"supported for PMECC, rolling back to Software ECC\n");

Why do you use backslashes?

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120516/4f2f1bd8/attachment-0001.sig>