[uClinux-dev] [PATCH] mtd: clean up uclinux.c map driver

Mike Frysinger vapier.adi at gmail.com
Tue May 15 22:42:59 EDT 2012


On Tue, May 15, 2012 at 8:45 PM, Greg Ungerer <gerg at snapgear.com> wrote:
> On 16/05/12 01:57, Mike Frysinger wrote:
>> On Tue, May 15, 2012 at 12:08 AM,<gerg at snapgear.com>  wrote:
>>>
>>> . make the struct uclinux_ram_map static
>>
>>
>> NAK: this breaks Blackfin systems.  we specifically don't want this to
>> be static.
>>
>> it should probably get a comment added above it saying as much.
>
> A comment won't fix the sparse warning. You need a proper declaration.

perhaps, but marking it static to fix a warning that people rarely see
whilst simultaneously knowingly breaking an arch doesn't sound like
the correct trade off.
-mike



More information about the linux-mtd mailing list