[PATCH 1/3] ARM: OMAP2+: gpmc: Modify interrupt handling
Mohammed, Afzal
afzal at ti.com
Tue May 15 11:06:43 EDT 2012
Hi Tony,
On Tue, May 15, 2012 at 20:08:34, Mohammed, Afzal wrote:
> Modify interrupt handling such that interrupts can be handled by GPMC
> client drivers using standard interrupt APIs rather than requiring
> the drivers to have knowledge about GPMC interrupt handling. Currently
> only NAND related interrupts has been considered (which is the case
> even without this change) as the only user of GPMC interrupt is NAND.
:
> - ret = request_irq(gpmc_irq, gpmc_handle_irq, IRQF_SHARED, "gpmc", NULL);
If this series could not be considered for 3.5, to prevent failure of
request_irq, either,
355f8ee ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse,
should be avoided, or diff [1] would be required, as shared irq needs dev-id.
Regards
Afzal
[1]
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 46b09da..9e1b726 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -768,7 +768,7 @@ static int __init gpmc_init(void)
irq++;
}
- ret = request_irq(gpmc_irq, gpmc_handle_irq, IRQF_SHARED, "gpmc", NULL);
+ ret = request_irq(gpmc_irq, gpmc_handle_irq, 0, "gpmc", NULL);
if (ret)
pr_err("gpmc: irq-%d could not claim: err %d\n",
gpmc_irq, ret);
More information about the linux-mtd
mailing list