Regarding latest EUCLEAN/bitflip_threshold patchset

Shmulik Ladkani shmulik.ladkani at gmail.com
Wed May 9 06:26:13 EDT 2012


Hi Mike,

I noticed 'nand_do_read_oob' explicitly tests 'mtd->ecc_stats.corrected'
and returns EUCLEAN - as it was not ported to use the new
'bitflip_threshold'.

From nand_base.c:

	if (mtd->ecc_stats.failed - stats.failed)
		return -EBADMSG;

	return  mtd->ecc_stats.corrected - stats.corrected ? -EUCLEAN : 0;

- May drivers increment mtd->ecc_stats.{corrected,failed} during their
  ecc.read_oob() call?

- If so, can we (should we?) report EUCLEAN according to the
  bitflip_threshold in this case?

Regards,
Shmulik



More information about the linux-mtd mailing list