[PATCH 2/2] MIPS: bcm63xx: kbuild: remove -Werror
Maciej W. Rozycki
macro at linux-mips.org
Sun May 6 03:06:15 EDT 2012
On Fri, 27 Apr 2012, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy at linux.intel.com>
>
> I cannot build bcm963xx with the standard Kbuild W=1 switch:
>
> arch/mips/bcm63xx/boards/board_bcm963xx.c: At top level:
> arch/mips/bcm63xx/boards/board_bcm963xx.c:647:5: error: no previous prototype for 'bcm63xx_get_fallback_sprom' [-Werror=missing-prototypes]
> cc1: all warnings being treated as errors
>
> This patch removes the gcc switch to make W=1 work. Mips is the only
> architecture I know which does not build with W=1 and this upsets my aiaiai
> scripts. And in general, you never know which warnings newer versions of gcc
> will start emiting so having -Werror by default is not the best idea.
If the function has no prototype, then it cannot be reasonably used from
outside -- perhaps you meant to mark it static instead?
Maciej
More information about the linux-mtd
mailing list