[PATCH v4 01/10] mtd: nand: add 'oob_required' argument to NAND {read, write}_page interfaces

[Brian Norris]

Hi Mike and Shmulik,

On Thu, May 3, 2012 at 10:43 AM, Shmulik Ladkani
<shmulik.ladkani at gmail.com> wrote:
>> Still, it seems inconsistent.  When calling the functions, you sometimes pass
>> the bool form...
>>
>> > -   status = docg4_read_page(mtd, nand, buf, DOCG4_FACTORY_BBT_PAGE);
>> > +   status = docg4_read_page(mtd, nand, buf, false, DOCG4_FACTORY_BBT_PAGE);
>>
>> and sometimes the int form...
>>
>> > -   chip->ecc.read_page_raw(mtd, chip, buf, page);
>> > +   chip->ecc.read_page_raw(mtd, chip, buf, 1, page);
>
> I guess the 'true/false' arguments are leftovers from Brian's previous
> posts...

Yes, accidental leftovers.

> I noted these while reviewing, and personally don't mind them, but I
> guess '0/1' are more appropriate.

Yes, these should all be 0/1. It shouldn't be a significant issue,
except for consistency.

Artem: I fixed these up and sent a fixup patch.

[Mike:] "Aside from that, you can add my Acked-by for the docg4 driver
if you like."

The docg4 stuff already went into l2-mtd-2.6.git; Artem can add the
Acked-by as he rebases.

Brian