[PATCH v3 0/10] sh_flctl hardware ECC mode cleanup

[Bastian Hecht]

Hi Artem,

2012/5/2 Artem Bityutskiy <dedekind1 at gmail.com>:
> On Wed, 2012-05-02 at 11:41 +0200, Bastian Hecht wrote:
>> changelog v3:
>>
>> Just a rebase on current l2-mtd.git.
>
> Aiaiai says that your patch-set introduced several warnings, could you
> please take a look:
>
> --------------------------------------------------------------------------------
>
> Bisectability test results for configuration "l2_mackerel_defconfig,arm,arm-unknown-linux-gnueabi-"
>
> Bisecability test passed
>
> --------------------------------------------------------------------------------
>
> Successfully built configuration "l2_mackerel_defconfig,arm,arm-unknown-linux-gnueabi-", results:
>
> --- before_patching.log
> +++ after_patching.log
> @@ @@
> -drivers/mtd/nand/sh_flctl.c:264:30: warning: incorrect type in argument 1 (different address spaces) [sparse]
> -drivers/mtd/nand/sh_flctl.c:264:30:    expected void const volatile [noderef] <asn:2>*<noident> [sparse]
> -drivers/mtd/nand/sh_flctl.c:264:30:    got void *fifo_addr [sparse]
> +drivers/mtd/nand/sh_flctl.c:301:38: warning: incorrect type in argument 1 (different address spaces) [sparse]
> +drivers/mtd/nand/sh_flctl.c:301:38:    expected void const volatile [noderef] <asn:2>*<noident> [sparse]
> +drivers/mtd/nand/sh_flctl.c:301:38:    got void *fifo_addr [sparse]
> +drivers/mtd/nand/sh_flctl.c:326:28: warning: cast removes address space of expression [sparse]
> +drivers/mtd/nand/sh_flctl.c:331:17: warning: incorrect type in argument 1 (different address spaces) [sparse]
> +drivers/mtd/nand/sh_flctl.c:331:17:    expected void const volatile [noderef] <asn:2>*<noident> [sparse]
> +drivers/mtd/nand/sh_flctl.c:331:17:    got void *fifo_addr [sparse]
> +drivers/mtd/nand/sh_flctl.c:967 flctl_probe() warn: 'irq' was not released on error [smatch]
>
> --------------------------------------------------------------------------------

Nice! Every day I learn about a new tool for kernel developing. I
cloned your aiaiai tree but am unsure how to run it as
CONFIG_MTD_NAND_SH_FLCTL is not set in the mackerel_defconfig. Can you
supply me with a command line how you tested it?

Thanks,

 Bastian Hecht


> --
> Best Regards,
> Artem Bityutskiy