[PATCH 4/4] MTD: drivers return max_bitflips, mtd returns -EUCLEAN

Artem Bityutskiy dedekind1 at gmail.com
Fri Mar 30 08:13:50 EDT 2012


On Thu, 2012-03-29 at 10:30 -0700, Brian Norris wrote:
> On Sun, Mar 11, 2012 at 2:21 PM, Mike Dunn <mikedunn at newsguy.com> wrote:
> > The drivers' read methods, absent an error, return a non-negative integer
> > indicating the maximum number of bit errors that were corrected in any one
> > writesize region.  MTD returns -EUCLEAN if this is >= euclean_threshold, 0
> > otherwise.  Note that this is a subtle change to the driver interface.
> >
> > This and the preceeding patches in this set were tested ubi on top of the
> > nandsim and docg4 devices, running the ubi test io_basic from mtd-utils.
> 
> Did you test any non-NAND devices? I'm getting the feeling that some
> of this is misguided or at least needs some fixing. See below.

Brian,

you are right, these 2 should be reverted and Mike should come back with
a better patch-set. I was not careful enough, and thanks for the review.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120330/625f5b3d/attachment.sig>


More information about the linux-mtd mailing list