[patch] Add cryptographic functionality when a key is passed to the compress / decompress functions
Artem Bityutskiy
dedekind1 at gmail.com
Tue Mar 27 04:33:08 EDT 2012
I guess you'll need to amend this patch if you change the previous one.
Also 2 nit-picks.
On Sun, 2012-03-25 at 23:38 +0200, Joel Reardon wrote:
> + if (err) {
> + ubifs_err("setkey() failed flags=%x",
Please, use %#x instead.
> + crypto_blkcipher_get_flags(tfm));
> + return err;
> + }
Indentation.
> + if (key) {
> + u8 iv[UBIFS_CRYPTO_KEYSIZE];
> + memset(iv, 0, UBIFS_CRYPTO_KEYSIZE);
Please to the same convention we use globally in UBIFS - put a blank
like between "iv" declaration and the "memset" invocation..
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120327/0c89c701/attachment.sig>
More information about the linux-mtd
mailing list