[PATCH] mtd: phram: dot not crash when built-in and passing boot param

Artem Bityutskiy dedekind1 at gmail.com
Tue Mar 13 09:23:55 EDT 2012


On Tue, 2012-03-13 at 10:52 +0100, h-fache at ti.com wrote:
> +/* This shall contain the module parameter if any. It is of the form:
> +   * phram=<device>,<address>,<size> for module case
> +   * phram.phram=<device>,<address>,<size> for built-in case
> +   We leave 64 bytes for the device name, 12 for the address and 12 for the
> +   size.
> +   Example: phram.phram=rootfs,0xa0000000,512Mi
> +*/

Sorry for this, but please, while you are on it, still, turn all your
comments into the standard Linux-style comments. This is not that
important, but just cleaner.

> +static __initdata char phram_paramline[64+12+12];

Despite that you told that there are not section mismatches, which I
doubted and thus decided to check, I see that this patch _does_ cause a
section mismatch:

+WARNING: modpost: Found 1 section mismatch(es).
+To see full details build your kernel with:

Could you please fix this?

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120313/f1ce10ce/attachment-0001.sig>


More information about the linux-mtd mailing list