[PATCH] mtd: nand: mxc_nand fix compiler warning

Alex Gershgorin alexg at meprolight.com
Tue Jun 12 09:39:33 EDT 2012


On Tue, Jun 12, 2012 at 02:18:07PM +0300, Alex Gershgorin wrote:
> This patch removes the following warning:
> drivers/mtd/nand/mxc_nand.c:1246: warning: initialization discards qualifiers from pointer target type
> drivers/mtd/nand/mxc_nand.c:1249: warning: initialization discards qualifiers from pointer target type
> drivers/mtd/nand/mxc_nand.c:1252: warning: initialization discards qualifiers from pointer target type
> drivers/mtd/nand/mxc_nand.c:1255: warning: initialization discards qualifiers from pointer target type
>
> Signed-off-by: Alex Gershgorin <alexg at meprolight.com>
>
> Applies to v3.5-rc2+
> ---
> >Better write the "Applies to" line after the tripple dash. Then this
> >info doesn't make it into the commit log. Instead point out the
> >offending commit.

Sorry my mistake

> >Having said that, I prefer to have

> >  http://mid.gmane.org/1335171381-24869-1-git-send-email-u.kleine-koenig@pengutronix.de
> > (and the follow-ups) applied. Casting away consts is nearly always
> > wrong.

I think this patch will solve the warnings problem only in mxc_nand driver, but this patch also creates
 new same problems to  other drivers that use struct of_device_id.

Thanks
Alex

>  drivers/mtd/nand/mxc_nand.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index c58e6a9..74b6e75 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -1243,16 +1243,16 @@ static const struct mxc_nand_devtype_data imx51_nand_devtype_data = {
>  static const struct of_device_id mxcnd_dt_ids[] = {
>       {
>               .compatible = "fsl,imx21-nand",
> -             .data = &imx21_nand_devtype_data,
> +             .data = (void *)&imx21_nand_devtype_data,
>       }, {
>               .compatible = "fsl,imx27-nand",
> -             .data = &imx27_nand_devtype_data,
> +             .data = (void *)&imx27_nand_devtype_data,
>       }, {
>               .compatible = "fsl,imx25-nand",
> -             .data = &imx25_nand_devtype_data,
> +             .data = (void *)&imx25_nand_devtype_data,
>       }, {
>               .compatible = "fsl,imx51-nand",
> -             .data = &imx51_nand_devtype_data,
> +             .data = (void *)&imx51_nand_devtype_data,
>       },
>       { /* sentinel */ }
>  };
> --
> 1.7.0.4
>
>

--
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-mtd mailing list