[PATCH] mtd: nand: Use the mirror BBT descriptor when reading its version
Sebastian Andrzej Siewior
bigeasy at linutronix.de
Sun Jun 10 13:02:30 EDT 2012
On 06/10/2012 12:58 PM, Shmulik Ladkani wrote:
> The code responsible for reading the version of the mirror bbt was
> incorrectly using the descriptor of the main bbt.
>
> Pass the mirror bbt descriptor to 'scan_read_raw' when reading the
> version of the mirror bbt.
>
> Signed-off-by: Shmulik Ladkani<shmulik.ladkani at gmail.com>
> ---
> - Spotted while reviewing BBT code.
> - Introduced by 7cba7b1 [mtd: nand: add support for BBT without OOB].
> - Looks like a typo.
> - Not runtime tested.
> - Sebastian, care to take a look and Ack?
Looks good.
Acked-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
> index 30d1319..c126469 100644
> --- a/drivers/mtd/nand/nand_bbt.c
> +++ b/drivers/mtd/nand/nand_bbt.c
> @@ -390,7 +390,7 @@ static int read_abs_bbts(struct mtd_info *mtd, uint8_t *buf,
> /* Read the mirror version, if available */
> if (md&& (md->options& NAND_BBT_VERSION)) {
> scan_read_raw(mtd, buf, (loff_t)md->pages[0]<< this->page_shift,
> - mtd->writesize, td);
> + mtd->writesize, md);
> md->version[0] = buf[bbt_get_ver_offs(mtd, md)];
> pr_info("Bad block table at page %d, version 0x%02X\n",
> md->pages[0], md->version[0]);
Sebastian
More information about the linux-mtd
mailing list