[PATCH 1/5] UBI: fastmap: add more TODOs

Artem Bityutskiy dedekind1 at gmail.com
Wed Jun 6 19:45:21 EDT 2012


On Thu, 2012-06-07 at 01:46 +0200, Richard Weinberger wrote:
> >> To catch UBI_IO_BAD_HDR, UBI_IO_BAD_HDR_EBADMSG and friends.
> > 
> > Which are never returned by ubi_io_read().
> 
> Also never ever in future?
> If so, I'll drop this check. 

Well, if you read those constants they suggest that they are specific to
functions which read the UBI headers. ubi_io_read() function is just a
general read function which is just a simple wrapper over mtd_read()
plus re-trying, nice error messaging, debugging prints, some error codes
handling, nothing else.

So no, it is not going to ever check UBI headers and return those codes.

/me goes to sleep.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120607/44d331e5/attachment.sig>


More information about the linux-mtd mailing list