[PATCH v2 1/2] mtd: maps: physmap: Add VPP regulator control
Pawel Moll
pawel.moll at arm.com
Mon Jul 23 14:42:09 EDT 2012
On Mon, 2012-07-23 at 19:32 +0100, Mark Brown wrote:
> The thing that's particularly bad here is that your change will just
> silently ignore the error which is far from awesome, at the very least
> it ought to complain (though I don't think that's a good idea).
I know, I don't like that myself - that's probably why I don't mind
dropping that change. Particularly that non-DT boards can always pass
set_vpp via platform data. And that's what will probably have to happen
here.
> It shouldn't be that hard to find the in-tree users...
It was in case of SMSC ethernet drivers ;-)
> Well, in the DT case it'll probably start returning -ENODEV soon if
> there's no supply binding set up (which would get you back to your
> current case),
This would be perfect. Will it happen for 3.7? If so, I'll drop the
non-OF patch and make the OF one rely on -ENODEV.
> given that you're from ARM probably that's covering all
> the cases you're especially interested in.
Indeed physmap_of is what really interests me. I added the non-DT code
to keep symmetry, but after all nature is not symmetrical after
all... ;-)
Cheers!
Paweł
More information about the linux-mtd
mailing list