[PATCH] mtd: add a new macro about the subpage write
Marek Vasut
marex at denx.de
Fri Jul 13 13:10:35 EDT 2012
Dear Brian Norris,
> On Fri, Jul 13, 2012 at 9:53 AM, Marek Vasut <marex at denx.de> wrote:
> >> On 07/13/2012 11:08 AM, Huang Shijie wrote:
> >> > On Fri, Jul 13, 2012 at 11:40 AM, Marek Vasut <marex at denx.de> wrote:
> >> >> Why not remove the mask?
> >> >
> >> > I do not understand why this line was added here, was it added on
> >> > purpose? so I am not sure whether we can just remove this line.
> >>
> >> If whoever wanted that line to be there cared enough, they could have
> >> justified it with a comment (in the code, in the changelog, or in one of
> >> these threads). We can't just let cruft sit there (or worse, produce
> >> more cruft to work around existing cruft) just because we don't know
> >> exactly what the original author was thinking. It appears to just have
> >> been a misguided attempt at enforcing any given option to come from only
> >> one place.
> >
> > I think it was there to allow having two different chips on the same NAND
> > bus ... or something. But this is just a guess. Anyway, it proved
> > irrelevant, so let's drop it.
>
> I agree. Then review/test/ack my patch that I just sent :)
It's in the queue, as I'm really interested to see this finally fixed.
> Brian
Best regards,
Marek Vasut
More information about the linux-mtd
mailing list