[PATCH 1/2] mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver

[David Woodhouse]

On Mon, 2012-07-09 at 16:08 +1000, Greg Ungerer wrote:
> 
> The only VM based arch this driver can be configured for currently
> is m68k (actually it is even more specific, only CONFIG_COLDFIRE).
> And that doesn't support HIGHMEM.

OK, can we at least have a comment to that effect in the code, alongside
that phys_to_virt() call so that nobody is tempted to copy it into new
code? And preferably also an '#ifdef CONFIG_HIGHMEM / #error' in the
code or a (redundant) !HIGHMEM dependency in Kconfig just to make sure,
in case it's ever enabled on other architectures or in case HIGHMEM ever
comes to m68k.
 
> Can the kernels data region (and the area immediately after it) be in
> high memory? 

No, that'll be in the directly mapped region.

-- 
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6171 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120712/27d6a46a/attachment-0001.bin>