[PATCH 1/2] mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver

[David Woodhouse]

On Thu, 2012-05-10 at 16:55 +1000, gerg at snapgear.com wrote:
> But if we want to use the uclinux.c mapping driver on real MMU enabled
> systems we should be using phys_to_virt() for the translation, since
> that is really what we are doing. So change it to do that. 

That seems wrong. On a highmem page, phys_to_virt() isn't valid. So at
the very least, any usage of phys_to_virt() needs a stonking great
comment explaining why it's always safe because it can never be used ona
a highmem page.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6171 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120706/00e37412/attachment.bin>