[GIT PULL] logfs: bug fixes
Linus Torvalds
torvalds at linux-foundation.org
Tue Jan 31 22:36:25 EST 2012
On Tue, Jan 31, 2012 at 7:07 PM, Brian Norris
<computersforpeace at gmail.com> wrote:
>
> For your (hopefully temporary) resolution, mtd_can_have_bb() should
> return 1, not 0. Or better yet, do not change mtd_can_have_bb() right
> now. Always returning 0 is interpreted as "the MTD cannot have bad
> blocks," which is dangerous for MTD's that *do* support bad blocks.
Right you are. That was just a thinko on my part.
So together with the point that logfs should have dropped the use of
mtd_can_have_bb(), the fix to that merge should be the attached patch
- at least then things should hopefully work.
That still leaves the question of whether the MTD people want to
change the semantics in other ways. Sorry for the mis-merge,
Linus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 1278 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120131/595c53dc/attachment.bin>
More information about the linux-mtd
mailing list