[PATCH] mtd: nand: gpmi: use correct member for checking NAND_BBT_USE_FLASH

Brian Norris computersforpeace at gmail.com
Tue Jan 31 12:42:18 EST 2012


On Tue, Jan 31, 2012 at 4:10 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
> This has been moved from .options to .bbt_options meanwhile. So, it
> currently checks for something totally different (NAND_OWN_BUFFERS) and
> decides according to that.
>
> Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
> Cc: Huang Shijie <b32955 at freescale.com>
> ---
>
> Artem: NAND_OWN_BUFFERS should not get set, so no danger. But I'd think we
> should add the stable tag nonetheless if Huang is fine with this change.

Acked-by: Brian Norris <computersforpeace at gmail.com>

And the "stable" tag is probably good, since the "options" ->
"bbt_options" split was a few releases ago. I guess I missed this one.

Also, you might note that there are some changes in progress with the
default NAND "block_markbad" routine, which you may or may not want to
reflect in the overriding "gpmi_block_markbad" routine eventually.

Brian



More information about the linux-mtd mailing list