[PATCH 2/2] ubinfo: fix `--all' for non-consecutive device numbers
Brian Norris
computersforpeace at gmail.com
Thu Jan 26 02:31:50 EST 2012
When we have assigned non-consecutive device numbers to our UBI devices,
then we run `ubinfo --all', we get errors once ubinfo tries to process the
devices in the "hole". For instance, suppose there are two UBI devices,
/dev/ubi0 and /dev/ubi10; then, ubinfo will fail trying to open /dev/ubi1
with:
ubinfo: error!: cannot get information about UBI device 1
error 2 (No such file or directory)
This patch adds a check to first see if device is present, then continue
to the next ID if it doesn't exist.
Reported-by: Brian Foster <brian.foster at maxim-ic.com>
Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
ubi-utils/ubinfo.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ubi-utils/ubinfo.c b/ubi-utils/ubinfo.c
index 7aa4aa4..cb88f53 100644
--- a/ubi-utils/ubinfo.c
+++ b/ubi-utils/ubinfo.c
@@ -362,6 +362,8 @@ static int print_general_info(libubi_t libubi, int all)
for (i = ubi_info.lowest_dev_num;
i <= ubi_info.highest_dev_num; i++) {
+ if (!ubi_dev_present(libubi, i))
+ continue;
if(!first)
printf("\n===================================\n\n");
first = 0;
--
1.7.5.4
More information about the linux-mtd
mailing list