[PATCH] MTD: docg4: fix compiler warning

Mike Dunn mikedunn at newsguy.com
Fri Jan 20 17:12:49 EST 2012


This changes the declaration of the module parameter variable from int to bool,
an oversight that was flagged by the recent patch to moduleparam.h.

Also added an item to the TODO list in the commentary at the top of the file.

Signed-off-by: Mike Dunn <mikedunn at newsguy.com>
---
 drivers/mtd/nand/docg4.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c
index 0132745..3ec1d10 100644
--- a/drivers/mtd/nand/docg4.c
+++ b/drivers/mtd/nand/docg4.c
@@ -20,6 +20,11 @@
  *
  *  Hamming ecc when reading oob only
  *
+ *  According to the M-Sys documentation, this device is also available in a
+ *  "dual-die" configuration having a 256MB capacity, but no mechanism for
+ *  detecting this variant is documented.  Currently this driver assumes 128MB
+ *  capacity.
+ *
  *  Support for multiple cascaded devices ("floors").  Not sure which gadgets
  *  contain multiple G4s in a cascaded configuration, if any.
  *
@@ -48,8 +53,8 @@
  * it does not use mtd nand's method for marking bad blocks (using oob area).
  * This will also skip the check of the "page written" flag.
  */
-static int ignore_badblocks;
-module_param(ignore_badblocks, bool, false);
+static bool ignore_badblocks;
+module_param(ignore_badblocks, bool, 0);
 MODULE_PARM_DESC(ignore_badblocks, "no badblock checking performed");
 
 struct docg4_priv {
-- 
1.7.3.4




More information about the linux-mtd mailing list