[PATCH 1/4] mtd: nand: erase block before marking bad

Brian Norris computersforpeace at gmail.com
Mon Jan 16 14:18:09 EST 2012


On Mon, Jan 16, 2012 at 4:07 AM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Fri, 2012-01-13 at 18:11 -0800, Brian Norris wrote:
>> Many NAND flash systems (especially those with MLC NAND) cannot be
>> reliably written twice in a row. For instance, when marking a bad block,
>> the block may already have data written to it, and so we should attempt
>> to erase the block before writing a bad block marker to its OOB region.
>
> All four look good, pushed to l2-mtd.git, thanks.

Sorry, but actually this "erase block before marking bad" patch is
incorrect. I didn't test this particular revision, and so I forgot
that the erase fails because the block is already marked as bad:

  nand_erase_nand: attempt to erase a bad block at page 0x...

I'll send a fixup patch on top of l2-mtd-2.6.

> What are your plans WRT marking blocks as bad both in the OOB and the
> table?

I don't have a 100% definite plan, but I've been trying to track the
comments/suggestions in the other thread. I'll reply to that thread so
we have the right reply-chain and CC list for discussion.

Brian



More information about the linux-mtd mailing list