[PATCH] cfi: AMD/Fujitsu compatibles: add panic write support

Artem Bityutskiy dedekind1 at gmail.com
Tue Jan 10 17:06:26 EST 2012


On Tue, 2012-01-10 at 08:38 -0800, Ira W. Snyder wrote:
> On Tue, Jan 10, 2012 at 11:26:23AM +0100, Florian Fainelli wrote:
> > Hello,
> > 
> > On 01/06/12 20:29, Ira W. Snyder wrote:
> > > This allows the mtdoops driver to work on flash chips using the
> > > AMD/Fujitsu compatible command set.
> > >
> > > As the code comments note, the locks used throughout the normal code
> > > paths in the driver are ignored, so that the chance of writing out the
> > > kernel's last messages are maximized.
> > 
> > This patch made me looking at the panic code, but should not this be 
> > made conditionnal to the enabling/disabling of the MTD oops driver?
> > 
> 
> It is reasonable to make this code conditional based on CONFIG_MTD_OOPS.
> The mtdoops driver is the only user of mtd->panic_write().

I think we should not break layering - the driver should not know about
entities like mtdoops which are at upper layers. It is like making a
disk driver conditional on file-systems.

Artem.




More information about the linux-mtd mailing list