[PATCH (mtd-www) 5/7] nand-data: add columns to the table

Brian Norris computersforpeace at gmail.com
Mon Jan 9 14:38:13 EST 2012


On Thu, Jan 5, 2012 at 8:13 AM, Angus CLARK <angus.clark at st.com> wrote:
> Add the following columns to the table:
>        - "Scan Page 1"
>        - "No. CS"
>        - "No. LUNs"
>        - "No. R/B#"
>        - "I/0 I/F"
>        - "Base Part"

These patches get a little harder to deal with when there are columns
added, since line-by-line diff is pretty useless! I kinda predicted
this would be a problem when I chose CSV format, but I don't see much
better alternatives that would be efficient (e.g., XML could work, but
that's a lot of overhead for tags, etc.) Anyway, I have a few
comments.

Potential unintended changes:

* Under the ONFI column, you changed "1.0" to just "1" (on, for
example, Numonyx NAND04GR3B2). I'm guessing that your CSV editor did
this automatically, treating it like an integer. It's not exactly
incorrect, but I think it works nicer to appear as 1.0. Perhaps (as a
separate patch), these can all be changed to quoted strings (their
entries do not have quotes ATM) to prevent arbitrary editor handling?

Regarding new content:

* I was thinking of adding "Scan Page 1" at some point, just for
completeness. Thanks.
* Scan page 1: you missed Samsung K9XDG08U5D, which should have 'Scan
Page 1 = FALSE'
* CS, LUNs, R/B#: looks good, although I didn't do in-depth review of
*all* the data sheets :)
* I/O I/F: is this an abbreviation for "Input/Output Interfaces"?
* Under the "Base Part" column, you have a typo where "M29F2G08AAC"
should be "MT29F2G08AAC"
* When you list "NAND04G-B2D" in the "Base Part" column, can you
either use the lowercase "x" for a wildcard as we discussed or just
state the exact chip name when possible?

Overall, I've been a little fuzzy on how various multi-LUN
configurations are handled; mostly, I deal with single-CS chips, but I
thought I was getting the hang of how multiple LUNs were introduced
via the CS and R/B pins. However, I see that there are occasionally
multi-LUN chips where `Num. LUNs > Num. CS'. Apparently, there are
multiple LUNs on the same CE# and R/B# lines. Are such LUNs handled
transparently, such that no special board wiring is needed and that
software doesn't notice a difference? And is this where multi-plane
operations come into the picture?

Similarly, I'm not sure of the exact meaning of I/O I/F (as asked
above). I see that it is delineated in some datasheets as "number of
I/O", but it's not clearly defined.

In light of some of the confusions above, perhaps we should add a
little bit of a legend/key on the web version of the table. We can
handle that after this patch goes through. The only changes I request
for now are regarding the 1.0 vs 1 change and the small "Base Part"
discrepancies and typos.

Thanks a lot!

Brian



More information about the linux-mtd mailing list