GPMI-NAND: Wrong ECC size in driver

Marek Vasut marek.vasut at gmail.com
Thu Jan 5 04:07:54 EST 2012


> Hi,
> 
> >> I will be happy if the driver works only by setting the
> >> 
> >> >  NAND_NO_SUBPAGE_WRITE, without setting the ecc.size.
> > 
> > So you intentionally set the ecc.size to 1 to work around the issue?
> 
> yes.
> I read the code, and it seemed setting the ecc.size to 1 is the right
> solution.
> 
> Best Regards
> Huang Shijie

It's definitelly wrong because it relies on undefined behaviour! The right 
solution here is to fix NAND_NO_SUBPAGE_WRITE pass-through as Scott and I 
proposed.

M



More information about the linux-mtd mailing list