[PATCH 1/3] libmtd: perform device checking first

Artem Bityutskiy dedekind1 at gmail.com
Thu Feb 9 07:07:49 EST 2012


On Thu, 2012-02-09 at 14:05 +0200, Artem Bityutskiy wrote:
> On Wed, 2012-02-08 at 13:26 -0800, Brian Norris wrote:
> > If we don't check for the MTD before calling `legacy_get_dev_info1', we may
> > get errors like:
> > 
> > libmtd: MTD subsystem is old and does not support sysfs, so MTD character device nodes have to exist
> > libmtd: error!: "/dev/mtd2" is not a character device
> > mtdinfo: error!: libmtd failed get MTD device 2 information
> >          error 22 (Invalid argument)
> > 
> > So reverse the order of these two checks.
> > 
> > Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> 
> Looks good, thanks, but could you please send a version which applies to
> mtd-utils.git? The 3rd patch in this series does not apply.

Actually, I've pushed patches 1 and 2, would you please re-send the 3rd
one?

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120209/9a5ee0fd/attachment-0001.sig>


More information about the linux-mtd mailing list