[PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb()

Artem Bityutskiy dedekind1 at gmail.com
Tue Dec 4 03:15:01 EST 2012

On Tue, 2012-12-04 at 09:56 +0200, Artem Bityutskiy wrote:
> On Mon, 2012-12-03 at 20:57 +0100, Richard Weinberger wrote:
> > As ubi_self_check_all_ff() might sleep we are not allowed
> > to call it from atomic context.
> > For now we call it only from ubi_wl_get_peb().
> > There are some code paths where it would also make sense,
> > but these paths are currently atomic and only enabled
> > when fastmap is used.
> > 
> > Signed-off-by: Richard Weinberger <richard at nod.at>
> Can you confirm that you enabled the 3 debugging options I sent and
> tested both FM and non-FM configurations with those options enabled?

Let me elaborate why I am asking.

1. If you did the tests and with this fix the debugging stuff works
fine, then it is OK to take this patch now and let you improve the FM
debugging coverage a bit later.

2. If you did not verify, then the assumption is _may_ be broken anyway,
then I would prefer to not take this patch, because I consider it to be
a band aid.

Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20121204/9efb6aee/attachment.sig>

More information about the linux-mtd mailing list