[PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb()

Artem Bityutskiy dedekind1 at gmail.com
Tue Dec 4 02:55:15 EST 2012


On Mon, 2012-12-03 at 20:57 +0100, Richard Weinberger wrote:
> +	err = ubi_self_check_all_ff(ubi, peb, ubi->vid_hdr_aloffset,
> +				    ubi->peb_size - ubi->vid_hdr_aloffset);
> +	if (err) {
> +		ubi_err("new PEB %d does not contain all 0xFF bytes", peb);
> +		return err;
> +	}
> +

The original idea was to verify that all PEBs from the free list (tree
actually) are really filled with 0xFFs.

What I see is that with fastmap this is not done.

I think the code should be re-thought and re-structured to make the
verification happen with fastmap enabled as well.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20121204/79f94315/attachment.sig>


More information about the linux-mtd mailing list