[PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs
Artem Bityutskiy
dedekind1 at gmail.com
Thu Aug 30 02:43:43 EDT 2012
On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote:
> This patch is based on the assumption that all the partitions are
> in the right offset order.
>
> Assume we have a 1GB(8Gb) nand chip, and we set the partitions
> in the command line like this:
> #gpmi-nand:100m(boot),100m(kernel),1g(rootfs)
>
> In this case, the partition truncating occurs. The current code will
> get the following result:
>
> ----------------------------------
> root at freescale ~$ cat /proc/mtd
> dev: size erasesize name
> mtd0: 06400000 00040000 "boot"
> mtd1: 06400000 00040000 "kernel"
> ----------------------------------
>
> It is obvious that we lost the truncated partition `rootfs` which should
> be 824M in this case.
>
> Why? The old code sets the wrong partitions number when the truncating
> occurs. This patch fixes it. Alao add a `break` to shortcut the code in this
> case.
>
> After apply this patch, the result becomes:
> ----------------------------------
> root at freescale ~$ cat /proc/mtd
> dev: size erasesize name
> mtd0: 06400000 00040000 "boot"
> mtd1: 06400000 00040000 "kernel"
> mtd2: 33800000 00040000 "rootfs"
> ----------------------------------
>
> We get the right result.
>
> Signed-off-by: Huang Shijie <shijie8 at gmail.com>
Should this have CC to -stable?
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120830/73adb167/attachment.sig>
More information about the linux-mtd
mailing list