[PATCH V4] mtd: m25p80: Make fast read configurable via DT

Marek Vasut marek.vasut at gmail.com
Sat Aug 25 10:06:48 EDT 2012


Dear Artem Bityutskiy,

> On Thu, 2012-08-23 at 15:41 +0200, Marek Vasut wrote:
> > Add DT property "m25p,fast-read" that signalises the particular
> > chip supports "fast read" opcode.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> > Cc: David Woodhouse <david.woodhouse at intel.com>
> 
> Does not compile if (I think) OF is not enabled.
> 
> drivers/mtd/devices/m25p80.c: In function 'm25p_probe':
> drivers/mtd/devices/m25p80.c:920:2: error: implicit declaration of function
> 'of_property_read_bool' [-Werror=implicit-function-declaration] cc1: some
> warnings being treated as errors
> make[4]: *** [drivers/mtd/devices/m25p80.o] Error 1

Argh, of course. Wrapping that part in ifdef CONFIG_OF should do the trick. So 
much for having CONFIG_OF on all the time.

Thanks!

Best regards,
Marek Vasut



More information about the linux-mtd mailing list