[PATCH] mtd: nand: Rename create_bbt()'s 'len' variable to 'numpages'

Brian Norris computersforpeace at gmail.com
Fri Aug 24 20:18:22 EDT 2012


On Mon, Aug 20, 2012 at 6:29 AM, Shmulik Ladkani
<shmulik.ladkani at gmail.com> wrote:
> Rename 'len' variable of create_bbt/scan_block_fast/scan_block_full to
> 'numpages', since it really means number of pages to scan when
> searching for the BBM (and not the byte length of the scan).
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani at gmail.com>

Thanks, this kind of fix is actually very helpful! It's kinda annoying
that I always have to translate in my head the fact that 'len' means
'number of pages.' And now that you mention it, I should have just
changed this myself a long time ago :)

BTW, some (all?) of this might die if I (or Matthieu) ever end up
polishing Matthieu's patches to utilize nand_chip->block_bad instead
of much of this code. But that's no issue.

I'm not sure what goes here. Acked-by? Reviewed-by? Gladly-welcomed-by?

Reviewed-by: Brian Norris <computersforpeace at gmail.com>



More information about the linux-mtd mailing list