[PATCH MTD-UTILS 5/5] ubiattach: introduce max_beb_per1024 in UBI_IOCATT

Richard Genoud richard.genoud at gmail.com
Wed Aug 22 09:31:46 EDT 2012


2012/8/22 Artem Bityutskiy <dedekind1 at gmail.com>:
> Good. But please, implement this double 'attach' invocation inside
> 'ubi_attach_mtd()'. Please, introduce a special return code to indicate
> the 'attached but max_beb_per1024 was ignored' case (say, 1). Add
> comments explaining the trick.

one question:
- does the call:
ubiattach -m 2 -b 0
should fail on an old kernel ?
In this case, I'll have to introduce a flag or something to let
ubi_attach_mtd() know that the -b option was given.
Honestly, I don't think it's necessary, as far as -b0 means "the
default kernel value", so on an old kernel the default that's what
will happened.

I'll have also to change the ubi_attach() call.
My though is to factorize code between ubi_attach_mtd() and
ubi_attach(), and then make the change.


Best regards,
Richard.



More information about the linux-mtd mailing list