[PATCH v3 4/6] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

[Richard Genoud]

2012/8/21 Artem Bityutskiy <dedekind1 at gmail.com>:
> Changed this to 'printk(KERN_ERR' and wrapped the line.
>
> The former is because the entire function uses 'printk(KERN_ERR', and I
> am a fan of consistency. We can change them all to 'pr_err()' and
> 'pr_warn()' in a separate patch.
>
> Similar for wrapping - UBI wraps all messages. If we want, we can unwrap
> them all in a separate patch.
>
> Feel free to submit such a patch, I won't have objections.
>
>> -MODULE_PARM_DESC(mtd, "MTD devices to attach. Parameter format: "
>> -                   "mtd=<name|num|path>[,<vid_hdr_offs>].\n"
>
> You unwrapped this one and I pushed that as is, because it is just much
> more readable, and it is the only place where we describe a module, so
> no inconsistencies. :-)
>
> Thank you!
>
> --
> Best Regards,
> Artem Bityutskiy

Looking for consistency, I made a quick git grep "\<printk( *KERN_" | wc -l
the answer is  > 32000
Looks like I found something to do if I'm getting bored with openstreetmap :)


I double checked linux-ubi/master tree with mine, it's all right.

I'll resend the mtd-utils part updated with the new kernel header ubi-user.h

Best regards

Richard.

-- 
for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?